Skip to content

change template format and text#4

Merged
smarcet merged 1 commit into
mainfrom
feature/password-reset-email-template
Mar 31, 2022
Merged

change template format and text#4
smarcet merged 1 commit into
mainfrom
feature/password-reset-email-template

Conversation

@romanetar

Copy link
Copy Markdown
Contributor

<tr>
<td align="center" style="font-size:0px;padding:10px 25px;word-break:break-word;">
<div style="font-family:open Sans Helvetica, Arial, sans-serif;font-size:16px;line-height:1;text-align:center;color:#000000;">You are receiving this email because you changed your password.</div>
<div style="font-family:open Sans Helvetica, Arial, sans-serif;font-size:16px;line-height:1;text-align:center;color:#000000;">The password was reset for FNid <a href="#" style="text-decoration:none !important;color:black !important; cursor:default !important; font-weight:bold">{!!$user_email!!}</a>.</div>

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please dont explicitly mention FNid instead use {!! Config::get("app.name") !!}

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this has been fixed

@smarcet smarcet left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please review comments

Signed-off-by: romanetar <roman_ag@hotmail.com>
@romanetar
romanetar force-pushed the feature/password-reset-email-template branch from 1e70cc1 to 1c5a83c Compare December 22, 2021 19:14

@smarcet smarcet left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@smarcet
smarcet merged commit d706e75 into main Mar 31, 2022
smarcet pushed a commit that referenced this pull request Apr 21, 2022
Signed-off-by: romanetar <roman_ag@hotmail.com>
smarcet added a commit that referenced this pull request Jun 16, 2022
* home page refactor

Signed-off-by: romanetar <roman_ag@hotmail.com>

* signup page refactor

Signed-off-by: romanetar <roman_ag@hotmail.com>

* auth flow pages refactor

Signed-off-by: romanetar <roman_ag@hotmail.com>

* Allow to configure Welcome User email sending

added env variable MAIL_SEND_WELCOME_EMAIL=1|0

Signed-off-by: smarcet@gmail.com <smarcet@gmail.com>
Change-Id: Idbb5a3b054d8525520024c6082c64c40f0f5da70

* Updated default profile PIC for user

added new variable DEFAULT_PROFILE_IMAGE

Signed-off-by: smarcet@gmail.com <smarcet@gmail.com>
Change-Id: Idee436af38fcf272e90daf9ddf6c9bcb20b31322

* Added alt attribute to header image

Signed-off-by: smarcet@gmail.com <smarcet@gmail.com>
Change-Id: I510e355eda10aa75843e5d1d6b1fb1128d85dc7e

* Added social login process custom error

Signed-off-by: smarcet@gmail.com <smarcet@gmail.com>
Change-Id: Ib3b82b32374a70604943b63b2c1c198c4a0a24e1

* Fixed get ip address method

Signed-off-by: smarcet@gmail.com <smarcet@gmail.com>
Change-Id: I176d6bf9cb8bd8b3f8f663183e062b63378aa532

* User update by id

removed 403 if current user is not present

Signed-off-by: smarcet@gmail.com <smarcet@gmail.com>
Change-Id: I7c7c045f0f92d9fa90aa05b5cdf7b7b82cd461af

* Fixed login hint config rendering

Signed-off-by: smarcet@gmail.com <smarcet@gmail.com>
Change-Id: I5bca66f3acd3ba74acd0865301c4f55635b71cf2

* Added log info

Signed-off-by: smarcet@gmail.com <smarcet@gmail.com>
Change-Id: I08c03df0e9e0227b4d345bf6c15498076ccbcdb8

* Fixed missing sprintf

Signed-off-by: smarcet@gmail.com <smarcet@gmail.com>
Change-Id: Ic45e2aca15994d0479b5ba7766f8842b249fdf97

* Fix prompt logic

Signed-off-by: smarcet@gmail.com <smarcet@gmail.com>
Change-Id: Ibaa3b125ddd19e6e735e683f5ba98477b4eefa98

* Improved invalid offline access invalid error feedback

Signed-off-by: smarcet@gmail.com <smarcet@gmail.com>
Change-Id: I9e8fed69788b93c6e1a782e7220837e137a7706f

* Added log info

Signed-off-by: smarcet@gmail.com <smarcet@gmail.com>
Change-Id: Id521ad666c5d86c966ef8e779bf0c7c8ca8da9bf

* change template format and text (#4)

Signed-off-by: romanetar <roman_ag@hotmail.com>

* Sign in flow UI refactor (#7)

Signed-off-by: romanetar <roman_ag@hotmail.com>

* Markup and css tweaks

Signed-off-by: smarcet@gmail.com <smarcet@gmail.com>
Change-Id: Ibe65c64b554da0d6e3ceb85d2576aebbfe2c509a

* Fix on image logo link

redirect to /auth/login

Signed-off-by: smarcet@gmail.com <smarcet@gmail.com>
Change-Id: Iff4189f936966a95e95a94dffb6cc731fd1a545c

* Added missing variable

Signed-off-by: smarcet@gmail.com <smarcet@gmail.com>
Change-Id: I8ef980ff75c81edc96123d0676410de028afba87

* Fix on code of conduct alignment

Signed-off-by: smarcet@gmail.com <smarcet@gmail.com>
Change-Id: I5c1cc549cb7f1ed9472f1d9efde5e71f073a998e

Co-authored-by: smarcet@gmail.com <smarcet@gmail.com>
smarcet added a commit that referenced this pull request Jun 16, 2022
* home page refactor

Signed-off-by: romanetar <roman_ag@hotmail.com>

* signup page refactor

Signed-off-by: romanetar <roman_ag@hotmail.com>

* auth flow pages refactor

Signed-off-by: romanetar <roman_ag@hotmail.com>

* Allow to configure Welcome User email sending

added env variable MAIL_SEND_WELCOME_EMAIL=1|0

Signed-off-by: smarcet@gmail.com <smarcet@gmail.com>
Change-Id: Idbb5a3b054d8525520024c6082c64c40f0f5da70

* Updated default profile PIC for user

added new variable DEFAULT_PROFILE_IMAGE

Signed-off-by: smarcet@gmail.com <smarcet@gmail.com>
Change-Id: Idee436af38fcf272e90daf9ddf6c9bcb20b31322

* Added alt attribute to header image

Signed-off-by: smarcet@gmail.com <smarcet@gmail.com>
Change-Id: I510e355eda10aa75843e5d1d6b1fb1128d85dc7e

* Added social login process custom error

Signed-off-by: smarcet@gmail.com <smarcet@gmail.com>
Change-Id: Ib3b82b32374a70604943b63b2c1c198c4a0a24e1

* Fixed get ip address method

Signed-off-by: smarcet@gmail.com <smarcet@gmail.com>
Change-Id: I176d6bf9cb8bd8b3f8f663183e062b63378aa532

* User update by id

removed 403 if current user is not present

Signed-off-by: smarcet@gmail.com <smarcet@gmail.com>
Change-Id: I7c7c045f0f92d9fa90aa05b5cdf7b7b82cd461af

* Fixed login hint config rendering

Signed-off-by: smarcet@gmail.com <smarcet@gmail.com>
Change-Id: I5bca66f3acd3ba74acd0865301c4f55635b71cf2

* Added log info

Signed-off-by: smarcet@gmail.com <smarcet@gmail.com>
Change-Id: I08c03df0e9e0227b4d345bf6c15498076ccbcdb8

* Fixed missing sprintf

Signed-off-by: smarcet@gmail.com <smarcet@gmail.com>
Change-Id: Ic45e2aca15994d0479b5ba7766f8842b249fdf97

* Fix prompt logic

Signed-off-by: smarcet@gmail.com <smarcet@gmail.com>
Change-Id: Ibaa3b125ddd19e6e735e683f5ba98477b4eefa98

* Improved invalid offline access invalid error feedback

Signed-off-by: smarcet@gmail.com <smarcet@gmail.com>
Change-Id: I9e8fed69788b93c6e1a782e7220837e137a7706f

* Added log info

Signed-off-by: smarcet@gmail.com <smarcet@gmail.com>
Change-Id: Id521ad666c5d86c966ef8e779bf0c7c8ca8da9bf

* change template format and text (#4)

Signed-off-by: romanetar <roman_ag@hotmail.com>

* Sign in flow UI refactor (#7)

Signed-off-by: romanetar <roman_ag@hotmail.com>

* Markup and css tweaks

Signed-off-by: smarcet@gmail.com <smarcet@gmail.com>
Change-Id: Ibe65c64b554da0d6e3ceb85d2576aebbfe2c509a

* Fix on image logo link

redirect to /auth/login

Signed-off-by: smarcet@gmail.com <smarcet@gmail.com>
Change-Id: Iff4189f936966a95e95a94dffb6cc731fd1a545c

* Added missing variable

Signed-off-by: smarcet@gmail.com <smarcet@gmail.com>
Change-Id: I8ef980ff75c81edc96123d0676410de028afba87

* Fix on code of conduct alignment

Signed-off-by: smarcet@gmail.com <smarcet@gmail.com>
Change-Id: I5c1cc549cb7f1ed9472f1d9efde5e71f073a998e

Co-authored-by: smarcet@gmail.com <smarcet@gmail.com>
smarcet added a commit that referenced this pull request Jul 23, 2026
TwoFactorForm computed `expired` to show the countdown message but
never used it to gate submission. A submit after expiry always fails
server-side with mfa_verification_failed, which counts against the
2fa.rate:verify middleware's 3-attempt window - letting a user burn
that budget on guaranteed-fail submits and get 429-locked out of the
login flow entirely.

Disable the VERIFY button and short-circuit handleSubmit (Enter-key
defense in depth) once expired is true.

PR #142 review finding #4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants